Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3179 #3408

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Fixes #3179 #3408

merged 2 commits into from
Jun 22, 2023

Conversation

NikCharlebois
Copy link
Collaborator

Pull Request (PR) description

  • PPTenantIsolationSettings & PPTenantSettings
    • Handles the case where required permissions are not provided when using SPN authentication.

This Pull Request (PR) fixes the following issues

Copy link
Collaborator

@andikrueger andikrueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small comment in regards to the exception message

@@ -85,6 +85,10 @@ function Get-TargetResource
try
{
$tenantIsolationPolicy = Get-PowerAppTenantIsolationPolicy -TenantId $tenantid
if ($tenantIsolationPolicy.StatusCode -eq 403)
{
throw "Invalid permission for the application. If you are using a custom app registration to authenticate, make sure it is defined as a Power Platform admin management application."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add the link to the documentation on how to do so.


if ($settings.StatusCode -eq 403)
{
throw "Invalid permission for the application. If you are using a custom app registration to authenticate, make sure it is defined as a Power Platform admin management application."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above.

@NikCharlebois NikCharlebois merged commit 7757234 into microsoft:Dev Jun 22, 2023
2 checks passed
@NikCharlebois NikCharlebois deleted the Fixes-#3179 branch June 22, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exported PPTenantIsolationSettings invalid, cannot be converted
2 participants