You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Code duplication
state/stateRenderer.js and state/shapes.js both contain identical implementations of getRows function.
It should be broken out to a common function. It is also similar to the sanitize function in flowDb. A more generic approach could cater all those use cases.
Create a folder called 'common' with common functions that are shared between the diagrams.
The text was updated successfully, but these errors were encountered:
I like the idea of centralizing functionality. Perhaps later on there will be more to put there, like splitting text lines with the line break regex (haven't double-checked that, just came to my mind when I was reading this).
Code duplication
state/stateRenderer.js and state/shapes.js both contain identical implementations of getRows function.
It should be broken out to a common function. It is also similar to the sanitize function in flowDb. A more generic approach could cater all those use cases.
Create a folder called 'common' with common functions that are shared between the diagrams.
The text was updated successfully, but these errors were encountered: