From 9fa51578c6a51d90c3ded748c9670df1e9dd95e2 Mon Sep 17 00:00:00 2001
From: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Date: Thu, 14 May 2020 17:12:41 +0100
Subject: [PATCH] Fix installing from a readonly copy of synapse (#866)

It seems that, as of pip 20.1, pip likes to do an in-tree build of synapse when
you install it, which is pretty nasty when pip is running in a docker image.

We can work around this by copying the bits we need into a tarball and
installing from that. Ultimately I'd like to change the build pipelines to
build a wheel upfront, and use that for the sytest builds, which will be a more
accurate representation of how most people install synapse, but this is a
prerequisite.
---
 scripts/synapse_sytest.sh | 29 +++++++++++++++++++++--------
 1 file changed, 21 insertions(+), 8 deletions(-)

diff --git a/scripts/synapse_sytest.sh b/scripts/synapse_sytest.sh
index 7792ecd41..dd98e7e5f 100755
--- a/scripts/synapse_sytest.sh
+++ b/scripts/synapse_sytest.sh
@@ -9,7 +9,7 @@
 
 # Run the sytests.
 
-set -ex
+set -e
 
 cd "$(dirname $0)/.."
 
@@ -25,11 +25,6 @@ if [ -n "$MULTI_POSTGRES" ] || [ -n "$POSTGRES" ]; then
 
     # Start the database
     su -c 'eatmydata /usr/lib/postgresql/*/bin/pg_ctl -w -D $PGDATA start' postgres
-
-    su -c psql postgres <<< "show config_file"
-    su -c psql postgres <<< "show max_connections"
-    su -c psql postgres <<< "show full_page_writes"
-    su -c psql postgres <<< "show fsync"
 fi
 
 # Now create the databases
@@ -110,6 +105,24 @@ elif [ -n "$POSTGRES" ]; then
 
 fi
 
+# default value for SYNAPSE_SOURCE
+: ${SYNAPSE_SOURCE:=/src}
+
+# if we're running against a source directory, turn it into a tarball.  pip
+# will then unpack it to a temporary location, and build it.  (As of pip 20.1,
+# it will otherwise try to build it in-tree, which means writing changes to the
+# source volume outside the container.)
+#
+if [ -d "$SYNAPSE_SOURCE" ]; then
+    echo "Creating tarball from synapse source"
+    tar -C "$SYNAPSE_SOURCE" -czf /tmp/synapse.tar.gz \
+        synapse scripts setup.py README.rst synctl MANIFEST.in
+    SYNAPSE_SOURCE="/tmp/synapse.tar.gz"
+elif [ ! -r "$SYNAPSE_SOURCE" ]; then
+    echo "Unable to read synapse source at $SYNAPSE_SOURCE" >&2
+    exit 1
+fi
+
 if [ -n "$OFFLINE" ]; then
     # if we're in offline mode, just put synapse into the virtualenv, and
     # hope that the deps are up-to-date.
@@ -118,11 +131,11 @@ if [ -n "$OFFLINE" ]; then
     # (https://github.com/pypa/pip/issues/5402 possibly) where pip wants
     # to reinstall any requirements for the build system, even if they are
     # already installed.
-    /venv/bin/pip install --no-index --no-use-pep517 /src
+    /venv/bin/pip install --no-index --no-use-pep517 "$SYNAPSE_SOURCE"
 else
     # We've already created the virtualenv, but lets double check we have all
     # deps.
-    /venv/bin/pip install -q --upgrade --no-cache-dir /src[redis]
+    /venv/bin/pip install -q --upgrade --no-cache-dir "$SYNAPSE_SOURCE"[redis]
     /venv/bin/pip install -q --upgrade --no-cache-dir \
         lxml psycopg2 coverage codecov tap.py coverage_enable_subprocess