Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't reuse the encoder in the integration tests #18

Merged
merged 1 commit into from
Aug 8, 2020

Conversation

marten-seemann
Copy link
Member

On first use, the encoder emits the required insert count. When comparing the lengths between a value encoded with and without using the static table, we need to make sure that both of them include the same overhead.

@codecov-commenter
Copy link

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   91.42%   91.42%           
=======================================
  Files           5        5           
  Lines         233      233           
=======================================
  Hits          213      213           
  Misses         11       11           
  Partials        9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f89b93a...ae9d209. Read the comment docs.

@marten-seemann marten-seemann merged commit 844f320 into master Aug 8, 2020
@marten-seemann marten-seemann deleted the fix-encoder-reuse-in-integration-tests branch August 8, 2020 07:20
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants