Skip to content
This repository has been archived by the owner on Jun 11, 2022. It is now read-only.

README update re: Heroku's build process changes #155

Closed
ekilah opened this issue Feb 14, 2019 · 4 comments
Closed

README update re: Heroku's build process changes #155

ekilah opened this issue Feb 14, 2019 · 4 comments

Comments

@ekilah
Copy link

ekilah commented Feb 14, 2019

blog post: https://devcenter.heroku.com/changelog-items/1557
Extended FAQ: https://help.heroku.com/P5IMU3MP/heroku-node-js-build-script-change-faq

As far as I can tell, users of this repo will need to tell Heroku to skip running npm run build for them, because this buildpack takes care of that. Heroku's FAQ is pretty nice above, I'm suggesting a link out to it and/or a quick blurb in the README to say users should include heroku-postbuild in their package.json's scripts, as Heroku suggests.

@jmorrell
Copy link

👋 Hi, I wrote the FAQ and made the change

My hope is that once the buildpack is executing the build script, that this buildpack can do less work. If there's some issue with that I'm happy to help figure out a work-around.

@ekilah
Copy link
Author

ekilah commented Feb 14, 2019

👋
To be honest, I inherited the build setup on the project I'm working on, so I'm not intimately familiar with which pieces are supposed to do which bits. but a change like that would require some messaging if other users of this repo are doing what I understood I should do, which is to tell Heroku to no longer run npm run build for me

@mars
Copy link
Owner

mars commented Feb 14, 2019

Hi folks 🤓 Revising this buildpack for the new build process is on my list to work on very soon. I’ll update with a testable PR when it’s ready 🙌

@mars
Copy link
Owner

mars commented Feb 20, 2019

Ready for testing ➡️ #156

@mars mars closed this as completed in #156 Mar 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants