Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to change append status when zipping files #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add ability to change append status when zipping files #127

wants to merge 1 commit into from

Conversation

AKoulabukhov
Copy link

This feature allows to add files to existing archives using .addinZip status

Copy link
Collaborator

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got some comments. Also; missing tests to verify the AppendStatus options are working. Can you add these? Thanks!

public enum AppendStatus {
case create
case createAfter
case addinZip
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we call this addInZip instead? As we Add In Zip, right?

@@ -48,6 +48,23 @@ public enum ZipCompression: Int {
}
}

public enum AppendStatus {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some describing documentation to each case describing to the user what it does?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants