Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swift Package Manager support #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oliviermartin
Copy link

Add support for Swift Package Manager (SPM)

@oliviermartin oliviermartin mentioned this pull request Jan 16, 2018
@oliviermartin
Copy link
Author

Should implement #115

Copy link
Collaborator

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! I do miss some editions to the readme to update on the Swift Package Manager support. Also, some feedback inline.

header "unzip.h"
header "zip.h"
header "../unzip.h"
header "../zip.h"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you updating the module map paths here? Are these necessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants