Framework tests fail using ssh tunnels

[bradmann]

It looks like if there's a mismatch between the port number your browser is hitting and the actual port the test appserver is running on, test:easy-url() returns the port your browser provides, rather than the correct port.

[dmcassel]

I don't follow... can you clarify this?

[bradmann]

There are a few systems that we only have access to through ssh tunneling (ssh -L 9042:localhost:8042 ). It seems like when we setup the tunnel on a different external port than the actual port the service is running on, 2 of the tests in the "Framework Tests" section fail due to the port mismatch.

[grtjn]

Bit old ticket, but would be helpful to know which tests fail. Might save us setup a tunnel to reproduce ourselves. The test-helper seems to rely on xdmp:get-request-header("Host")..

[bradmann]

routing.xqy and site-index.xqy under "Framework Tests"

If you have a VM, just ssh to it using -L 10042:localhost:8042 and point your browser to http://localhost:10042/tests/

You may even be able to ssh to your local machine and reproduce, but I haven't attempted that to verify.

[grtjn]

Yep, that worked. It fails because it takes the port number from the browser, but it is doing an http-get against 'localhost', which is executed server-side. It should really simply use xdmp:get-request-port(). That seems to solve this. I will do a PR..

[grtjn]

Fixed in dev