Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are we passing correct POC remin term to ciso module? #313

Open
mnlevy1981 opened this issue Aug 24, 2018 · 1 comment
Open

Are we passing correct POC remin term to ciso module? #313

mnlevy1981 opened this issue Aug 24, 2018 · 1 comment
Assignees
Milestone

Comments

@mnlevy1981
Copy link
Collaborator

We pack POC%remin into marbl_particulate_share before we account for the sediment terms at the bottom of the column. Is this appropriate, or should carbon isotopes receive the updated POC%remin value?

I.e. should

if (POC%to_floor > c0) then
          POC%remin(k) = POC%remin(k) &
+ ((POC%to_floor - POC%sed_loss(k)) * dzr_loc)

come before

    ! Save some fields for use by other modules
    if (ciso_on) then
       POC_remin_fields(k)         = POC%remin(k)

Note: I'll comment here after #308 is accepted to point to the new locations of these blocks of code.

@mnlevy1981
Copy link
Collaborator Author

These blocks are in compute_particulate_terms(), which is in marbl_interior_tendency_mod.F90 following #308. POC_remin_fields is still being set before POC_remin accounts for sediment terms.

@mnlevy1981 mnlevy1981 added this to the MARBL1.0.0 milestone Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants