Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix render tests when updating gl-js to 274d2 #854

Closed
louwers opened this issue Feb 23, 2023 · 1 comment
Closed

Fix render tests when updating gl-js to 274d2 #854

louwers opened this issue Feb 23, 2023 · 1 comment
Labels
dependencies Pull requests that update a dependency file js-parity
Milestone
Update MapLibre G...

Comments

@louwers
Copy link
Collaborator

louwers commented Feb 23, 2023 •
edited
Loading

On the update-gl-js-to-274d215be3b7bb1af15a0bfa3c28ad7822f3251b branch I bumped MapLibre GL JS to 274d215be3b7bb1af15a0bfa3c28ad7822f3251b.

When I run the render tests (on macOS) with

./build/mbgl-render-test-runner --manifestPath metrics/macos-xcode11-release-style.json

I get the following result:

16 failed (1.2%)
12 errored (0.9%)

These should be fixed before merging.
@louwers louwers added the dependencies Pull requests that update a dependency file label Feb 23, 2023
@louwers
Copy link
Collaborator Author

louwers commented Mar 23, 2023

Change of plans #938

@louwers louwers closed this as not planned Won't fix, can't repro, duplicate, stale Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file js-parity
Projects
None yet
Milestone
Update MapLibre GL JS to v1.15.2
Development

No branches or pull requests
1 participant
@louwers