Track SymbolManager image additions?

[Guardiola31337]

Follow up from mapbox/mapbox-navigation-android#1779 (comment)

@LukasPaczos:

The SymbolManager has a feature of keeping annotations alive across style changes. The issue here is, that when the style changes, you're not re-adding the icon image of the marker, so the manager doesn't have a resource to reference anymore.

The gist is, that you need to call something like

mapView.addOnDidFinishLoadingStyleListener(new MapView.OnDidFinishLoadingStyleListener() {
 @Override
 public void onDidFinishLoadingStyle() {
   mapboxMap.getStyle(new Style.OnStyleLoaded() {
     @Override
     public void onStyleLoaded(@NonNull Style style) {
       Bitmap markerBitmap = ThemeSwitcher.retrieveThemeMapMarker(mapView.getContext());
       style.addImage(MAPBOX_NAVIGATION_MARKER_NAME, markerBitmap);
     }
   });
 }
});

wherever it's best based on the navigation setup. The plugin will take care of the rest.

@Guardiola31337:

would it make sense for the SymbolManager to keep track of this as well?

Cutting this ticket to discuss if it'd make sense and implementation details.

@LukasPaczos:

adding an image is a separate entry point to the style object and exposing a duplicate method on the manager's side just to track additions would cause confusion imo. But maybe we could rethink that as an options parameter?

cc @LukasPaczos @danesfeder

[LukasPaczos]

If we'd like to move forward on this, another option would be exposing an interceptor of the Style object that would fire callbacks when an element is added.

[tobrun]

Linking #742 as this could be potentially in scope for that feature.

[tobrun]

This is moving in #1000, closing this already as it's a dupe of #742