Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Apply text-keep-upright after text-offset #9180

Closed
andrewharvey opened this issue Jun 2, 2017 · 4 comments
Closed

Apply text-keep-upright after text-offset #9180

andrewharvey opened this issue Jun 2, 2017 · 4 comments
Assignees
Labels
archived Archived because of inactivity Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS

Comments

@andrewharvey
Copy link
Contributor

Platform: Mapbox Raster Tiles API?
Mapbox SDK version:

equivalent of mapbox/mapbox-gl-js#2350

@kkaefer kkaefer added Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS labels Jun 3, 2017
@jfirebaugh
Copy link
Contributor

@ansis @ChrisLoer Was this included in recent text rendering PRs?

@ChrisLoer
Copy link
Contributor

@jfirebaugh Yeah, it should be handled here:

https://github.com/mapbox/mapbox-gl-native/blob/master/src/mbgl/layout/symbol_projection.cpp#L200

I tested the JS version with @andrewharvey 's jsbin: http://jsbin.com/danexuj/1/edit?html,output. The actual text-offset now works "as expected" (i.e. applied relative to line, not based on text direction). But the original example was actually using text-anchor: bottom instead of text-offset, which still behaves the same as before. Should it? It seems to me that it makes more sense for text-anchor to be based off of text direction.

@ChrisLoer
Copy link
Contributor

PR to enable the test on native: #9580

@stale stale bot added the archived Archived because of inactivity label Nov 5, 2018
@stale
Copy link

stale bot commented Dec 1, 2018

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Dec 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived Archived because of inactivity Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS
Projects
None yet
Development

No branches or pull requests

5 participants