-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Ensure Lint behaves the same in Debug and Release #8357
Comments
In order to accomplish this, we could add a At the moment, CI only includes steps that execute I checked those assumptions analyzing the dependency tree report of each task generated by Gradle Task Tree. Do we want to include lint errors on CI?
If we decide so, a great way to gradually introduce lint is to create a warnings baseline so:
@mapbox/android Thoughts? |
Further useful information: |
@Guardiola31337 Thanks for looking into this, I'm all for additional checks that could help us find potential issues earlier. I like the idea of activating lint using our current baseline as starting point. How does that baseline look like? Is it a XML file that we'd commit to the repo? |
Yeah, you only need to add
to
Cool thing is that lint warns/reminds you that one or more issues were filtered out because they were already listed in the baseline. Even if you fix issues included in the file it lets you know that it's a good time to recreate the baseline 👍 |
I'd like to see our current baseline. If the resulting file is easily readable we could manually remove items we don't want to whitelist. |
|
Lint behaves differently depending on the build type.
We should ensure that behaves the same in both Debug and Release in order to detect potential issues as soon as possible (e.g. #8356).
cc/ @zugaldia
The text was updated successfully, but these errors were encountered: