Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Replace MapChange enum and Backend::notifyMapChange with dedicated observer interface #6383

Closed
jfirebaugh opened this issue Sep 19, 2016 · 2 comments
Assignees
Labels
Core The cross-platform C++ core, aka mbgl refactor

Comments

@jfirebaugh
Copy link
Contributor

The MapChange enumeration values have their roots in MapKit semantics -- yet are increasingly deviating from those semantics, or expanding on them. We should replace them with an API that is less influenced by the API of a particular platform, and more influenced by the pattern we use elsewhere for observation, e.g. the style observer. It should be general enough that MapKit-like change notifications can be built on top of it.

@1ec5
Copy link
Contributor

1ec5 commented Sep 19, 2016

The MapChange enum was never particularly well-suited for MapKit semantics, either, because it was impossible to provide relevant context, such as a camera or error pointer, with a change notification. Awhile back, I started experimenting with making map change notifications more object oriented in the 1ec5-delegate-fail-loading-6142 branch, but imitating the style observer would be even better.

@jfirebaugh
Copy link
Contributor Author

Related: mapbox/mapbox-gl-js#3244

@jfirebaugh jfirebaugh changed the title Replace MapChange enum and View::notifyMapChange with dedicated observer interface Replace MapChange enum and Backend::notifyMapChange with dedicated observer interface Dec 16, 2016
@brunoabinader brunoabinader self-assigned this Mar 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl refactor
Projects
None yet
Development

No branches or pull requests

3 participants