Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

MGLStyle.styleClasses should be an NSSet #6104

Closed
1ec5 opened this issue Aug 21, 2016 · 2 comments
Closed

MGLStyle.styleClasses should be an NSSet #6104

1ec5 opened this issue Aug 21, 2016 · 2 comments
Labels
iOS Mapbox Maps SDK for iOS refactor runtime styling
Milestone

Comments

@1ec5
Copy link
Contributor

1ec5 commented Aug 21, 2016

We moved the style class API to MGLStyle for #5974. While we’re at it, we should change the type of MGLStyle.styleClasses from an NSArray of NSStrings to an NSSet of NSStrings, because the order doesn’t matter.

/cc @frederoni

@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS refactor runtime styling labels Aug 21, 2016
@1ec5 1ec5 added this to the ios-v3.4.0 milestone Aug 21, 2016
@jfirebaugh
Copy link
Contributor

the order doesn’t matter

I believe the order does matter. If multiple style classes set the same property, one of them wins, and this defines an ordering.

@1ec5
Copy link
Contributor Author

1ec5 commented Aug 21, 2016

Ah, that makes sense. In that case, we’ll eventually need to add more KVO accessors along the lines of #6097. We’re good here for the time being, though.

@1ec5 1ec5 closed this as completed Aug 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS refactor runtime styling
Projects
None yet
Development

No branches or pull requests

2 participants