Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Move inflate/deflate in FileSource to separate thread #3648

Closed
kkaefer opened this issue Jan 21, 2016 · 3 comments
Closed

Move inflate/deflate in FileSource to separate thread #3648

kkaefer opened this issue Jan 21, 2016 · 3 comments

Comments

@kkaefer
Copy link
Contributor

kkaefer commented Jan 21, 2016

We're currently calling inflate/deflate synchronously in the SQLiteCache. Instead, we should reserve this cache for SQLite operations exclusively and do other time-consuming tasks in a separate thread.

Once this is asynchronous, we can no longer guarantee an order of get/put operations, since compress tasks might run in parallel and can take more or less time compared to other cache tasks.

@jfirebaugh
Copy link
Contributor

What's the rationale?

@kkaefer
Copy link
Contributor Author

kkaefer commented Jan 21, 2016

It takes some time to decompress/compress the data. During this time, we can't do I/O with the the database.

@jfirebaugh
Copy link
Contributor

If we do #3722, we can't have asynchronicity within the database code. Instead, we should do #3886.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants