Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Mismatch between camera target and device location when in TRACKING (in China) #14846

Closed
langsmith opened this issue Jun 4, 2019 · 5 comments
Assignees
Labels
Android Mapbox Maps SDK for Android archived Archived because of inactivity bug

Comments

@langsmith
Copy link
Contributor

This ticket is to report a mismatch between the camera target and the actual device location, when the Mapbox China Plugin for Android is being used and the LocationComponent is in TRACKING camera mode.

Steps to reproduce

  1. Create a barebones Android app with a Mapbox map and the Mapbox China Plugin for Android (requires a special Mapbox China token).
  2. Also set up the LocationComponent with the TRACKING camera mode.

Expected behavior

The camera stays directly centered on the device location puck.

Actual behavior

The camera target location has a mismatch with the device's location (puck).

Configuration

Android versions: Pie
Device models: OnePlus 5
Mapbox SDK versions: 8.0.0

@langsmith langsmith added bug Android Mapbox Maps SDK for Android labels Jun 4, 2019
@langsmith
Copy link
Contributor Author

@LukasPaczos ' comments about this from a conversation elsewhere:

The shifter will translate all of the GeoJSON shapes (Point objects), that's why the puck is rendered at the correct place, but it won't impact the camera position (LatLng objects).

that Point.fromLngLat(latLng.getLongitude(), latLng.getLattitude()) is an often practice, which would result in double shifting. We should probably introduce the shifting whenever a raw LatLng is passed to core instead, which means a lot of entry points though.

@langsmith
Copy link
Contributor Author

cc @chriswu42 @Chaoba as fyi about this

@chriswu42
Copy link

@Chaoba can you look into this?

@Chaoba
Copy link
Contributor

Chaoba commented Jun 20, 2019

@chriswu42 No problem, I will address this issue.

@stale stale bot added the archived Archived because of inactivity label Dec 17, 2019
@stale
Copy link

stale bot commented Dec 17, 2019

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android archived Archived because of inactivity bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants