Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce feature "Hide glyphs behind the camera" #9334

Open
karimnaaji opened this issue Feb 24, 2020 · 2 comments
Open

Reintroduce feature "Hide glyphs behind the camera" #9334

karimnaaji opened this issue Feb 24, 2020 · 2 comments

Comments

@karimnaaji
Copy link
Contributor

karimnaaji commented Feb 24, 2020

1eed2ae commit from #9229 was reverted because of some potential driver issues on windows machine (reproduced on Intel Haswell chip), refer #9327 and #9333.

Now that we have a repro we should be able to pinpoint the problem and reintroduce the feature appropriately.

@ahk
Copy link
Contributor

ahk commented Feb 25, 2020

Thanks for following this. It's important to get this in to support higher pitch.

@mpulkki-mapbox do you have any thoughts on what was reverted that might have broken some platforms? It looks pretty innocuous to me.

@mpulkki-mapbox
Copy link
Contributor

Thanks for handling the case so quickly :).

The change was done in preparation for higher pitch angle support and it should have been invisible when pitch < 60. I'm quite sure the issue was caused by a bug in a recent graphics driver version from Intel. I found a possible fix and wrote about my findings #9327 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants