-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GeoJSON-triggered Chrome crash test case #790
Comments
Upstream says it's an OOM crash. |
Interesting. I wonder if there's something we can do to make this consume less memory? 1024 polygons are included, and are within the realm of Leaflet etc. |
@tmcw this happens probably because you're fetching this GeoJSON into the main thread, and then passing it to the worker. Loading big GeoJSON data in the worker directly (by passing the URL in the GeoJSONSourcce options instead) should work fine. |
I'll try that. Can you say more about what the difference is here? The size of the geojson isn't super huge - 600kb. Is the memory thing in the JSON transfer, or something else? |
Yeah, JSON load + transfer. Of course I'm not sure it's the culprit, but this is the first thing to try. |
It's not the JSON transfer, it's tiling the GeoJSON. GeoJSON is tiled at zooms 1, 5, 9, and 13. This GeoJSON generates 29700 tiles at z9 and 536580 tiles at z13, and the worker either takes forever to process that (master), or crashes (0.4.1). So basically this reduces to #464. |
Going to take a crack at fixing this, see #464 (comment) |
Triggers a sad-face tab crash in Chrome Version 38.0.2125.104
The text was updated successfully, but these errors were encountered: