Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom attribution strings have additional <p> tags causing layout problems (v0.51.0) #7589

Closed
joedjc opened this issue Nov 13, 2018 · 2 comments · Fixed by #7608
Closed

Comments

@joedjc
Copy link

joedjc commented Nov 13, 2018

Hi,

Since v0.51.0 custom attributions have additional <p> tags around them causing the layout to stack:

screenshot 2018-11-13 at 20 33 46

The pipe separator is also surrounded by <p> tags.

You can replicate using a simple example:

map.addControl(new mapboxgl.AttributionControl({customAttribution: "MY CUSTOM ATTRIBUTION"}));

I can resolve by reverting back to v0.50.0

@ryanhamley
Copy link
Contributor

This was introduced in https://github.com/mapbox/mapbox-gl-js/pull/7444/files to fix compact attributions. Looks like we need to make the <p> tags inline for full size attributions as well.

@andrewharvey
Copy link
Collaborator

also happening in https://www.mapbox.com/designer-maps/#cali-terrain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants