-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared collision detection between different sources #745
Comments
When moving this to a tile-only-level rather than a source/tile level, we are also going to face a few other issues: What happens when you are zooming in, you retain the parent tile and show one (but not all) child tiles that are within the retained parent tile? Do we "knock out" labels placed in the parent tile? |
@kkaefer don't we have the same issue currently within one source? |
Yes, but this is currently handled. This ticket is about sharing the collision detection between different sources. This gets a little trickier since you can enable/disable sources. |
Closing in favor of #1042 |
Currently if you add multiple sources to the map, collisions will be handled independently in each source, because source tiles are parsed independently. This makes it impossible for example to add GeoJSON labels and POIs that play nicely with OSM labels & POIs. The style defines how to make them play nice, but it's not reflected in the rendering.
Not sure how to approach this though — should we parse all labels & POIs separately and do it in one pass for all sources if a source is added/removed? This will affect performance a lot though. Should we just not handle this issue? Then the only way to use GeoJSON nicely will be to blend it in the VT source.
@ansis @kkaefer @edenh
The text was updated successfully, but these errors were encountered: