Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gl.texImage2D "Invalid argument" in IE 11 #7241

Closed
jfirebaugh opened this issue Sep 5, 2018 · 2 comments · Fixed by #7253
Closed

gl.texImage2D "Invalid argument" in IE 11 #7241

jfirebaugh opened this issue Sep 5, 2018 · 2 comments · Fixed by #7253

Comments

@jfirebaugh
Copy link
Contributor

Many examples started failing in IE 11 after #7171 with an "Invalid argument" error here:

gl.texImage2D(gl.TEXTURE_2D, 0, this.format, width, height, 0, this.format, gl.UNSIGNED_BYTE, image.data);

Guessing here, but maybe IE 11 does not like 0 for width and height, which didn't happen before #7171 but now it is?

cc @mourner

@mourner
Copy link
Member

mourner commented Sep 6, 2018

It's a good hypothesis, although I'm not sure how exactly that happens — does IE11 provide a stack trace?

@jfirebaugh
Copy link
Contributor Author

Stack trace has mangled names, but the line numbers look accurate to unminified source:

ms.prototype.update [Line: 73, Col: 17], texture.js
ms [Line: 49, Col: 5], texture.js
eu.prototype.upload [Line: 252, Col: 13], tile.js
i.prototype.prepare [Line: 171, Col: 30], source_cache.js
Zi.prototype.render [Line: 299, Col: 13], painter.js
o.prototype._render [Line: 1642, Col: 9], map.js
Anonymous function [Line: 1683, Col: 17], map.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants