Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.45.0 breaks mapbox-gl-directions plugin/example #6642

Closed
pathmapper opened this issue May 8, 2018 · 2 comments · Fixed by #6697
Closed

v0.45.0 breaks mapbox-gl-directions plugin/example #6642

pathmapper opened this issue May 8, 2018 · 2 comments · Fixed by #6697
Assignees
Labels
needs investigation 🔍 Issues that require further research (e.g. it's not clear whether it's GL JS or something else)

Comments

@pathmapper
Copy link
Contributor

pathmapper commented May 8, 2018

mapbox-gl-js version: v0.45.0

browser: Chrome

Steps to Trigger Behavior

  1. Open https://jsbin.com/gipahagera/edit?html,output
  2. Click somewhere on the route between A and B and drag the route

auswahl_277

Expected Behavior

Destination (B) is not moved and the route is adapted as with v0.44.2
https://jsbin.com/zidemesofe/edit?html,output

auswahl_276

Actual Behavior

Destination (B) is moved

image

Also reproducible with:
https://www.mapbox.com/mapbox-gl-js/example/mapbox-gl-directions/

@mollymerp
Copy link
Contributor

@pathmapper I'm not sure if this is a bug in mapbox-gl-js, it seems like a bug with how mapbox-gl-directions depends on events from gl-js, which changed since 0.44.* (#6218). I will look into it and move this issue over to the plugin repo if this is the case.

@mollymerp mollymerp added the needs investigation 🔍 Issues that require further research (e.g. it's not clear whether it's GL JS or something else) label May 10, 2018
@pathmapper
Copy link
Contributor Author

@mollymerp I was also unsure where to open this issue and ended up posting it here since #6218 wasn't listed as breaking change in the v0.45.0 release notes.

Anyway, thanks for looking into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs investigation 🔍 Issues that require further research (e.g. it's not clear whether it's GL JS or something else)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants