-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geoJSON source setData should cancel outstanding setData #6256
Comments
This was supposed to be fixed in 0.44.1 with #5902. Could you please create a minimal self-contained example on jsbin.com that demonstrates the issue so we can take a look? cc @ChrisLoer |
Just to clarify, the expected behavior after #5902 is that the first call should run to completion, and after it finishes, the result of the last |
ok, think I've put together a mcve. It connects to an azure web service that gives it a few geoJSON points. Click on the "Change the geojson" button and it calls set data twice, the first call has a delay on the server side. The data sets to the second call and then reverts to the first. Thanks, please say if my example doesn't work I've not used jsbin before. |
Thanks @jdeboer-geoplan! I can reproduce the problem using your jsbin, although strangely I don't see the behavior if I run the same code locally (but still hitting your azure service). I'll look into it soon. |
🤦♂️ Oops! #5902 was reverted due to a different bug and reimplemented in #5988, which unfortunately went into Thanks for putting the effort into the very clear repro case... I wish I had caught that #5902 wasn't actually in |
Ah great I'll look forward to the next release. thanks @ChrisLoer |
Hi brilliant project.
I've got a small issuette.
mapbox-gl-js version:
Originally found in 0.38.0 but have updated to 0.44.1 and still see the same results.
Steps to Trigger Behavior
Expected Behavior
The map should display the second geoJSON
Actual Behavior
The layer displays the second geoJSON and then the first overwrites it.
I'm not sure a synchronous version like #2275 is what I want, I think I just want setData to abort any previous operation when it gets called again.
The text was updated successfully, but these errors were encountered: