-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'anchor' option for Markers #5640
Comments
Happy to take a crack at it if no one has it in their queue n_n Do we want to export a Lines 22 to 27 in f11b764
|
@jay-manday I don't think anyone's claimed it yet, so please feel free!
Couldn't hurt! |
I thiiiink i have things working as needed though would love a review of my work before making a PR to the master branch on your end. I did some digging on the origins of the issue and was a pretty cool learning experience! 🌀💡🎉✨ Heres the work done on my fork: I also went ahead and manually wrote the test for the marker file too. n_n |
Hi @jay-manday nice to see you implementing this! Feel free to go ahead and open that PR as that's where the review typically takes place, even if you feel it's not 100% ready, you can just mention it's a WIP. The options for Popup's anchor are |
Hi @andrewharvey, totally! I'll make a PR and we can further discuss the work so far. Thanks for pointing me in the right direction as to the desired anchor options. I think I went down a wrong turn with my reasoning, while investigating how the marker renders onto the map I made the assumption that we wanted to anchor the marker via pixel values rather than css. I will definitely will factor this into my PR. n_n |
Following up from #4751, it would be nice to add an 'anchor' option for
Marker
, similar to the one inPopup
:mapbox-gl-js/src/ui/popup.js
Lines 37 to 42 in f11b764
The text was updated successfully, but these errors were encountered: