Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hash to be in lng,lat order #4748

Closed
mollymerp opened this issue May 24, 2017 · 5 comments
Closed

Change hash to be in lng,lat order #4748

mollymerp opened this issue May 24, 2017 · 5 comments
Labels
breaking change ⚠️ Requires a backwards-incompatible change to the API good first issue needs discussion 💬

Comments

@mollymerp
Copy link
Contributor

Ah, the age old question...

The Hash class is, to my knowledge, the only part of mapbox-gl-js that uses lat, lng order instead of lng, lat. I can't find any information about why this might be, but I would guess that it is to do with the old map-feedback site. In future releases (after #4685 🚢 ), gl-js maps attribution control will link to the new feedback site, so changing the Hash hopefully won't have downstream complications from that. 💭

Does anyone know why changing this might be problematic? @mapbox/gl-core

@mollymerp mollymerp added breaking change ⚠️ Requires a backwards-incompatible change to the API needs discussion 💬 good first issue labels May 24, 2017
@jfirebaugh
Copy link
Contributor

It's not just the map-feedback site, it's any site that uses Hash -- all Mapbox API embed pages, for example. This would be an extremely disruptive change and I don't think it would be worth it.

@mollymerp
Copy link
Contributor Author

Aw dang. Isn't api-styles the only one that uses mapbox-gl though? Or do you just mean for preserving consistency between all mapbox embed sites?

@jfirebaugh
Copy link
Contributor

Yeah, any site that uses Hash would be affected. If we change the format, and the site updates to the new version, any existing permalinks using the old format would stop working.

@peterqliu
Copy link
Contributor

peterqliu commented May 24, 2017

I think we originally did lat-lng for consistency with Google.

If we change the format, and the site updates to the new version, any existing permalinks using the old format would stop working.

A bit more kludge, but we could add a new hash parameter that communicates what order the coordinates should be interpreted in 😅 (would default to lat-lng for backward compatibility)

@mollymerp
Copy link
Contributor Author

I'm going to close for now because this is not high priority and depends on a number of things external to mapbox-gl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change ⚠️ Requires a backwards-incompatible change to the API good first issue needs discussion 💬
Projects
None yet
Development

No branches or pull requests

3 participants