Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lay out CJK text vertically in point-placed labels #3470

Closed
1ec5 opened this issue Oct 26, 2016 · 5 comments
Closed

Lay out CJK text vertically in point-placed labels #3470

1ec5 opened this issue Oct 26, 2016 · 5 comments
Assignees
Milestone

Comments

@1ec5
Copy link
Contributor

1ec5 commented Oct 26, 2016

As the next step after #1246, we should allow point-placed labels containing Chinese, Japanese, or Korean text to be laid out as vertical text only if a horizontal layout would collide with another feature. Vertical layout means that characters progress from top to bottom and lines progress from right to left, while the glyphs themselves remain unrotated. As discussed in #3438 (comment), Mongolian is written top to bottom, left to right, with glyph rotation; however, that script would be a much lower priority than CJK.

The primary use case for this feature is to better accommodate modern CJK text that can be written vertically if needed but is usually written horizontally. For antique-looking CJKV maps, it would be desirable to support a writing-mode layout property that forces vertical text even when horizontal text could be accommodated.

/cc @lucaswoj @xrwang @nickidlugash @andreasviglakis

@nickidlugash
Copy link

@1ec5 I don't know that it makes sense to support this before we support alternative horizontal placements of point labels to minimize collisions. I think this will make our maps harder to read, and most Chinese maps at least don't do this.

@1ec5
Copy link
Contributor Author

1ec5 commented Oct 26, 2016

I won’t speak to priorities; CJK text is an area of continuous improvement rather than a project we can call complete. I want to reiterate this clause in the original description:

when a horizontal layout would collide with another feature

That is, I fully agree that this feature would depend on alternative label placements. Furthermore, this feature is indeed common in Japanese maps, as seen for instance in mapbox/mapbox-gl-native#1682 (comment).

@nickidlugash
Copy link

nickidlugash commented Oct 26, 2016

I fully agree that this feature would depend on alternative label placements.

👍 Ok great, my concern was regarding pushing live vertical placements before alternative horizontal placements went live.

@asheemmamoowala
Copy link
Contributor

Moving in #8399

@asheemmamoowala
Copy link
Contributor

Closed in #8399

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants