From 1fee5f1e4034541e4fc0160cacc2ba2d44b3b57e Mon Sep 17 00:00:00 2001 From: Ryan Hamley Date: Mon, 7 Oct 2019 16:12:34 -0700 Subject: [PATCH] Avoid throwing styleimagemissing event for empty strings (#8840) --- src/data/bucket/symbol_bucket.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/data/bucket/symbol_bucket.js b/src/data/bucket/symbol_bucket.js index d1cad2d312a..b506c48f61e 100644 --- a/src/data/bucket/symbol_bucket.js +++ b/src/data/bucket/symbol_bucket.js @@ -382,7 +382,7 @@ class SymbolBucket implements Bucket { // this allows us to fire the styleimagemissing event if image evaluation returns null // the only way to distinguish between null returned from a coalesce statement with no valid images // and null returned because icon-image wasn't defined is to check whether or not iconImage.parameters is an empty object - const hasIcon = iconImage.value.kind !== 'constant' || !!iconImage.value.value || Object.keys(iconImage.parameters).length > 0; + const hasIcon = (iconImage.value.kind !== 'constant' || !!iconImage.value.value) && Object.keys(iconImage.parameters).length > 0; const symbolSortKey = layout.get('symbol-sort-key'); this.features = [];