You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 21, 2022. It is now read-only.
When accessibleLabelProperty isn’t set, queryFeatures() should set the aria-label attribute based on the evaluated value of the text-field property. Each feature in the feature querying results has a layer property that contains the evaluated values. This way, whatever a sighted user sees is exactly what a screenreader user would hear. Using the evaluated text-field value would even solve #6 as a side effect, since it would account for any changes already made by the gl-language plugin.
Great idea. However I think mapbox-gl-accessibility should provide an option to use the evaluated value of the text-field or a feature property. Since:
Not all accessible layers will have labels, but you might still want to allow users to tab through them and get a descriptive aria-label, eg :speaking_head: for 🗣️
Sometimes the aria-label should be different to the label. eg. When doing clustering using you might want accessible element for the cluster to have an aria-label of Cluster containing 6 items instead of the text-field of 6.
PS. Thanks for open sourcing this, it makes sense to try to have a shared library that everyone can use rather than everyone trying to implement it themselves within their application.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When
accessibleLabelProperty
isn’t set,queryFeatures()
should set thearia-label
attribute based on the evaluated value of thetext-field
property. Each feature in the feature querying results has alayer
property that contains the evaluated values. This way, whatever a sighted user sees is exactly what a screenreader user would hear. Using the evaluatedtext-field
value would even solve #6 as a side effect, since it would account for any changes already made by the gl-language plugin.mapbox-gl-accessibility/index.js
Line 41 in 3a2d6b6
/cc @tristen @lukasmartinelli
The text was updated successfully, but these errors were encountered: