diff --git a/MapboxAndroidDemo/src/main/java/com/mapbox/mapboxandroiddemo/examples/labs/DashedLineDirectionsPickerActivity.java b/MapboxAndroidDemo/src/main/java/com/mapbox/mapboxandroiddemo/examples/labs/DashedLineDirectionsPickerActivity.java index 6c7288ba9..69062cdd6 100644 --- a/MapboxAndroidDemo/src/main/java/com/mapbox/mapboxandroiddemo/examples/labs/DashedLineDirectionsPickerActivity.java +++ b/MapboxAndroidDemo/src/main/java/com/mapbox/mapboxandroiddemo/examples/labs/DashedLineDirectionsPickerActivity.java @@ -47,6 +47,9 @@ public class DashedLineDirectionsPickerActivity extends AppCompatActivity implements OnMapReadyCallback, MapboxMap.OnCameraIdleListener { + private static final String DIRECTIONS_LAYER_ID = "DIRECTIONS_LAYER_ID"; + private static final String LAYER_BELOW_ID = "road-label-small"; + private static final String SOURCE_ID = "SOURCE_ID"; private MapView mapView; private MapboxMap mapboxMap; private FeatureCollection dashedLineDirectionsFeatureCollection; @@ -117,16 +120,15 @@ public void onCameraIdle() { * to the place picker location */ private void initDottedLineSourceAndLayer(@NonNull Style loadedMapStyle) { - dashedLineDirectionsFeatureCollection = FeatureCollection.fromFeatures(new Feature[] {}); - loadedMapStyle.addSource(new GeoJsonSource("SOURCE_ID", dashedLineDirectionsFeatureCollection)); + loadedMapStyle.addSource(new GeoJsonSource(SOURCE_ID)); loadedMapStyle.addLayerBelow( new LineLayer( - "DIRECTIONS_LAYER_ID", "SOURCE_ID").withProperties( + DIRECTIONS_LAYER_ID, SOURCE_ID).withProperties( lineWidth(4.5f), lineColor(Color.BLACK), lineTranslate(new Float[] {0f, 4f}), lineDasharray(new Float[] {1.2f, 1.2f}) - ), "road-label-small"); + ), LAYER_BELOW_ID); } /** @@ -185,7 +187,7 @@ public void onStyleLoaded(@NonNull Style style) { directionsRouteFeatureList.add(Feature.fromGeometry(LineString.fromLngLats(coordinates))); } dashedLineDirectionsFeatureCollection = FeatureCollection.fromFeatures(directionsRouteFeatureList); - GeoJsonSource source = style.getSourceAs("SOURCE_ID"); + GeoJsonSource source = style.getSourceAs(SOURCE_ID); if (source != null) { source.setGeoJson(dashedLineDirectionsFeatureCollection); } diff --git a/MapboxAndroidDemo/src/main/java/com/mapbox/mapboxandroiddemo/examples/labs/RecyclerViewOnMapActivity.java b/MapboxAndroidDemo/src/main/java/com/mapbox/mapboxandroiddemo/examples/labs/RecyclerViewOnMapActivity.java index 08ee571da..906954ad8 100644 --- a/MapboxAndroidDemo/src/main/java/com/mapbox/mapboxandroiddemo/examples/labs/RecyclerViewOnMapActivity.java +++ b/MapboxAndroidDemo/src/main/java/com/mapbox/mapboxandroiddemo/examples/labs/RecyclerViewOnMapActivity.java @@ -93,7 +93,6 @@ public void onStyleLoaded(@NonNull Style style) { } private void initFeatureCollection() { - featureCollection = FeatureCollection.fromFeatures(new Feature[] {}); List featureList = new ArrayList<>(); if (featureCollection != null) { for (LatLng latLng : coordinates) { diff --git a/MapboxAndroidDemo/src/main/res/values/activity_strings.xml b/MapboxAndroidDemo/src/main/res/values/activity_strings.xml index cf3f37a23..1d6d906b5 100644 --- a/MapboxAndroidDemo/src/main/res/values/activity_strings.xml +++ b/MapboxAndroidDemo/src/main/res/values/activity_strings.xml @@ -491,4 +491,5 @@ Duration: Color: Select +