diff --git a/apiserver/plane/app/views/notification/base.py b/apiserver/plane/app/views/notification/base.py index 743b94b4ffe..b8e34339ce5 100644 --- a/apiserver/plane/app/views/notification/base.py +++ b/apiserver/plane/app/views/notification/base.py @@ -41,7 +41,7 @@ def get_queryset(self): ) @allow_permission( - allowed_roles=[ROLE.ADMIN, ROLE.MEMBER], + allowed_roles=[ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST], level="WORKSPACE", ) def list(self, request, slug): @@ -207,7 +207,7 @@ def mark_read(self, request, slug, pk): return Response(serializer.data, status=status.HTTP_200_OK) @allow_permission( - allowed_roles=[ROLE.ADMIN, ROLE.MEMBER], level="WORKSPACE" + allowed_roles=[ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST], level="WORKSPACE" ) def mark_unread(self, request, slug, pk): notification = Notification.objects.get( @@ -219,7 +219,7 @@ def mark_unread(self, request, slug, pk): return Response(serializer.data, status=status.HTTP_200_OK) @allow_permission( - allowed_roles=[ROLE.ADMIN, ROLE.MEMBER], level="WORKSPACE" + allowed_roles=[ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST], level="WORKSPACE" ) def archive(self, request, slug, pk): notification = Notification.objects.get( @@ -231,7 +231,7 @@ def archive(self, request, slug, pk): return Response(serializer.data, status=status.HTTP_200_OK) @allow_permission( - allowed_roles=[ROLE.ADMIN, ROLE.MEMBER], level="WORKSPACE" + allowed_roles=[ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST], level="WORKSPACE" ) def unarchive(self, request, slug, pk): notification = Notification.objects.get( @@ -286,7 +286,7 @@ def get(self, request, slug): class MarkAllReadNotificationViewSet(BaseViewSet): @allow_permission( - allowed_roles=[ROLE.ADMIN, ROLE.MEMBER], level="WORKSPACE" + allowed_roles=[ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST], level="WORKSPACE" ) def create(self, request, slug): snoozed = request.data.get("snoozed", False) diff --git a/web/core/components/issues/peek-overview/view.tsx b/web/core/components/issues/peek-overview/view.tsx index 2c64ecaaf4a..7bc63c00c01 100644 --- a/web/core/components/issues/peek-overview/view.tsx +++ b/web/core/components/issues/peek-overview/view.tsx @@ -145,11 +145,12 @@ export const IssueView: FC = observer((props) => { "0px 4px 8px 0px rgba(0, 0, 0, 0.12), 0px 6px 12px 0px rgba(16, 24, 40, 0.12), 0px 1px 16px 0px rgba(16, 24, 40, 0.12)", }} > - {isLoading && } - {isError && ( + {isError ? (
+ ) : ( + isLoading && )} {!isLoading && !isError && issue && ( <> diff --git a/web/core/constants/dashboard.ts b/web/core/constants/dashboard.ts index ef3b6fda3e6..00a3fd52601 100644 --- a/web/core/constants/dashboard.ts +++ b/web/core/constants/dashboard.ts @@ -325,7 +325,7 @@ export const SIDEBAR_USER_MENU_ITEMS: { key: "notifications", label: "Inbox", href: `/notifications`, - access: [EUserPermissions.ADMIN, EUserPermissions.MEMBER], + access: [EUserPermissions.ADMIN, EUserPermissions.MEMBER, EUserPermissions.GUEST], highlight: (pathname: string, baseUrl: string) => pathname.includes(`${baseUrl}/notifications/`), Icon: Inbox, }, diff --git a/web/next.config.js b/web/next.config.js index 80ff7a79e23..1d191da3d84 100644 --- a/web/next.config.js +++ b/web/next.config.js @@ -21,7 +21,7 @@ const nextConfig = { value: "origin-when-cross-origin", }, { key: "Cross-Origin-Opener-Policy", value: "same-origin" }, - { key: "Cross-Origin-Embedder-Policy", value: "require-corp" }, + { key: "Cross-Origin-Embedder-Policy", value: "credentialless" }, ], }, ];