From 2d6ce7bc879f35ebe6eaaded463af986f3b94b66 Mon Sep 17 00:00:00 2001 From: dakshesh14 Date: Thu, 14 Sep 2023 20:52:10 +0530 Subject: [PATCH 1/3] fix: activity not coming for duplicate, relatesd to and for blocked/blocking refactor: mutation logic to use relation id instead of issue id --- web/components/core/activity.tsx | 43 ++++++++++++++++++- .../issues/sidebar-select/blocked.tsx | 2 +- .../issues/sidebar-select/blocker.tsx | 13 ++++-- 3 files changed, 51 insertions(+), 7 deletions(-) diff --git a/web/components/core/activity.tsx b/web/components/core/activity.tsx index c8f6377b789..84170f5d85e 100644 --- a/web/components/core/activity.tsx +++ b/web/components/core/activity.tsx @@ -2,8 +2,9 @@ import { useRouter } from "next/router"; // icons import { Icon, Tooltip } from "components/ui"; +import { CopyPlus } from "lucide-react"; import { Squares2X2Icon } from "@heroicons/react/24/outline"; -import { BlockedIcon, BlockerIcon } from "components/icons"; +import { BlockedIcon, BlockerIcon, RelatedIcon } from "components/icons"; // helpers import { renderShortDateWithYearFormat } from "helpers/date-time.helper"; import { capitalizeFirstLetter } from "helpers/string.helper"; @@ -157,7 +158,7 @@ const activityDetails: { }, icon: , }, - blocks: { + blocked_by: { message: (activity) => { if (activity.old_value === "") return ( @@ -176,6 +177,44 @@ const activityDetails: { }, icon: , }, + duplicate: { + message: (activity) => { + if (activity.old_value === "") + return ( + <> + marked this issue as duplicate of{" "} + {activity.new_value}. + + ); + else + return ( + <> + removed this issue as a duplicate of{" "} + {activity.old_value}. + + ); + }, + icon: , + }, + relates_to: { + message: (activity) => { + if (activity.old_value === "") + return ( + <> + marked that this issue relates to{" "} + {activity.new_value}. + + ); + else + return ( + <> + removed the relation from{" "} + {activity.old_value}. + + ); + }, + icon: , + }, cycles: { message: (activity, showIssue, workspaceSlug) => { if (activity.verb === "created") diff --git a/web/components/issues/sidebar-select/blocked.tsx b/web/components/issues/sidebar-select/blocked.tsx index 9554a83bae7..d24814b0e5b 100644 --- a/web/components/issues/sidebar-select/blocked.tsx +++ b/web/components/issues/sidebar-select/blocked.tsx @@ -111,7 +111,7 @@ export const SidebarBlockedSelect: React.FC = ({ {blockedByIssue && blockedByIssue.length > 0 ? blockedByIssue.map((relation) => (
= ({ const blockerIssue = watch("issue_relations")?.filter((i) => i.relation_type === "blocked_by") || []; + console.log("blockerIssue: ", watch()); + // console.log("leng: ", blockerIssue.length); + const onSubmit = async (data: ISearchIssueResponse[]) => { if (data.length === 0) { setToastAlert({ @@ -83,6 +86,8 @@ export const SidebarBlockerSelect: React.FC = ({ ], }) .then((response) => { + console.log("response: ", response); + submitChanges({ issue_relations: [ ...blockerIssue, @@ -118,7 +123,7 @@ export const SidebarBlockerSelect: React.FC = ({ {blockerIssue && blockerIssue.length > 0 ? blockerIssue.map((relation) => (
= ({ type="button" className="opacity-0 duration-300 group-hover:opacity-100" onClick={() => { - const updatedBlockers = blockerIssue.filter( - (i) => i.issue_detail?.id !== relation.issue_detail?.id - ); + const updatedBlockers = blockerIssue.filter((i) => i.id !== relation.id); + + console.log("updatedRelations: ", updatedBlockers); submitChanges({ issue_relations: updatedBlockers, From 3073f1c3f722a00e248eed9003e1049a48432e88 Mon Sep 17 00:00:00 2001 From: dakshesh14 Date: Fri, 15 Sep 2023 14:41:06 +0530 Subject: [PATCH 2/3] fix: mutation logic and changed keys to be aligned with api --- .../issues/sidebar-select/blocked.tsx | 6 +-- .../issues/sidebar-select/blocker.tsx | 10 +---- .../issues/sidebar-select/duplicate.tsx | 38 +++++++++---------- .../issues/sidebar-select/relates-to.tsx | 38 +++++++++---------- web/components/issues/sidebar.tsx | 38 ++++++++----------- web/components/web-view/activity-message.tsx | 35 ++++++++++++++++- web/services/issues.service.ts | 1 + web/types/issues.d.ts | 20 +++------- 8 files changed, 94 insertions(+), 92 deletions(-) diff --git a/web/components/issues/sidebar-select/blocked.tsx b/web/components/issues/sidebar-select/blocked.tsx index d24814b0e5b..d7e448377c8 100644 --- a/web/components/issues/sidebar-select/blocked.tsx +++ b/web/components/issues/sidebar-select/blocked.tsx @@ -73,7 +73,7 @@ export const SidebarBlockedSelect: React.FC = ({ ...selectedIssues.map((issue) => ({ issue: issueId as string, relation_type: "blocked_by" as const, - related_issue_detail: issue.blocked_issue_detail, + issue_detail: issue.blocked_issue_detail, related_issue: issue.blocked_issue_detail.id, })), ], @@ -115,13 +115,13 @@ export const SidebarBlockedSelect: React.FC = ({ className="group flex cursor-pointer items-center gap-1 rounded-2xl border border-custom-border-200 px-1.5 py-0.5 text-xs text-red-500 duration-300 hover:border-red-500/20 hover:bg-red-500/20" > - {`${relation.related_issue_detail?.project_detail.identifier}-${relation.related_issue_detail?.sequence_id}`} + {`${relation.issue_detail?.project_detail.identifier}-${relation.issue_detail?.sequence_id}`}