From e7b78399528c4f89da0c50fdc53c0c141635ca86 Mon Sep 17 00:00:00 2001 From: "rudraswamy.c" Date: Mon, 27 May 2024 10:24:41 +0530 Subject: [PATCH 1/2] PWA-3285 : Update networkUtils.js to check saveData mode --- .../src/ServiceWorker/Utilities/networkUtils.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/venia-concept/src/ServiceWorker/Utilities/networkUtils.js b/packages/venia-concept/src/ServiceWorker/Utilities/networkUtils.js index 29de8d7f43..3e6453e3c7 100644 --- a/packages/venia-concept/src/ServiceWorker/Utilities/networkUtils.js +++ b/packages/venia-concept/src/ServiceWorker/Utilities/networkUtils.js @@ -9,7 +9,11 @@ * @returns {boolean} */ export const isFastNetwork = () => { - if (navigator.connection && 'effectiveType' in navigator.connection) { + if ( + navigator.connection || + (navigator.connection.saveData && + 'effectiveType' in navigator.connection) + ) { return navigator.connection.effectiveType === '4g'; } else { /** From ca5627ecd856ca44db3385a2cc4034052bbf2207 Mon Sep 17 00:00:00 2001 From: "rudraswamy.c" Date: Mon, 27 May 2024 10:48:20 +0530 Subject: [PATCH 2/2] PWA-3285 : checked undefined condition for saveData and effectiveType --- .../src/ServiceWorker/Utilities/networkUtils.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/venia-concept/src/ServiceWorker/Utilities/networkUtils.js b/packages/venia-concept/src/ServiceWorker/Utilities/networkUtils.js index 3e6453e3c7..ad92909682 100644 --- a/packages/venia-concept/src/ServiceWorker/Utilities/networkUtils.js +++ b/packages/venia-concept/src/ServiceWorker/Utilities/networkUtils.js @@ -10,9 +10,9 @@ */ export const isFastNetwork = () => { if ( - navigator.connection || - (navigator.connection.saveData && - 'effectiveType' in navigator.connection) + navigator.connection && + navigator.connection.saveData !== undefined && + navigator.connection.effectiveType !== undefined ) { return navigator.connection.effectiveType === '4g'; } else {