fix DONT_FRAGMENT error when using a IPv6 connection on Windows #3178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The syscall setting the IP_DONTFRAGMENT socket option will fail if the underlying connection is a IPv6 connection. Since Go doesn't allow us to distinguish between IPv6 and dual-stack connections, we can only ignore the error here.
Codecov Report
@@ Coverage Diff @@
## master #3178 +/- ##
==========================================
+ Coverage 85.35% 85.37% +0.01%
==========================================
Files 133 133
Lines 9824 9819 -5
==========================================
- Hits 8385 8382 -3
+ Misses 1063 1062 -1
+ Partials 376 375 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The syscall setting the IP_DONTFRAGMENT socket option will fail if the underlying connection is a IPv6 connection. Since Go doesn't allow us to distinguish between IPv6 and dual-stack connections, we can only ignore the error here.