Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant nil-check in the packet packer #3048

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

q191201771
Copy link
Contributor

No description provided.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #3048 (d16f36a) into master (bfad411) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3048      +/-   ##
==========================================
+ Coverage   86.17%   86.20%   +0.03%     
==========================================
  Files         132      132              
  Lines        9352     9350       -2     
==========================================
+ Hits         8059     8060       +1     
+ Misses        936      934       -2     
+ Partials      357      356       -1     
Impacted Files Coverage Δ
packet_packer.go 84.65% <ø> (+0.35%) ⬆️
internal/utils/rand.go 75.00% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfad411...d16f36a. Read the comment docs.

@marten-seemann
Copy link
Member

@q191201771 Can you please sign the CLA? This is a requirement for merging this PR.

@q191201771
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@marten-seemann marten-seemann changed the title the pointer is always not nil, no need to check it remove redundant nil-check in the packet packer Feb 19, 2021
@marten-seemann marten-seemann merged commit 972a08c into quic-go:master Feb 19, 2021
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants