fix flaky key update integration test #3005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3005 +/- ##
==========================================
+ Coverage 86.12% 86.18% +0.06%
==========================================
Files 135 135
Lines 9443 9480 +37
==========================================
+ Hits 8132 8170 +38
Misses 953 953
+ Partials 358 357 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can receive a packet with key phase 0 and immediately update to key phase 1, without ever having sent a packet with key phase 0.
Equivalently, it might happen that we receive a packet with key phase N containing the CONNECTION_CLOSE, and never reply with a packet in key phase N.