Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publicize QUIC varint reading and writing #2973

Merged
merged 2 commits into from
Jan 2, 2021
Merged

Conversation

marten-seemann
Copy link
Member

Packages outside of quic-go might want to make use of QUIC's varint format. We should expose the respective functions, so they don't have to reimplement this.

Specifically, MASQUE uses varints for the Stream Chunk encoding.

@codecov
Copy link

codecov bot commented Jan 1, 2021

Codecov Report

Merging #2973 (f922688) into master (602212e) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2973      +/-   ##
==========================================
- Coverage   86.12%   86.03%   -0.09%     
==========================================
  Files         135      135              
  Lines        9379     9448      +69     
==========================================
+ Hits         8077     8128      +51     
- Misses        943      959      +16     
- Partials      359      361       +2     
Impacted Files Coverage Δ
framer.go 100.00% <100.00%> (ø)
http3/client.go 88.61% <100.00%> (ø)
http3/frames.go 80.00% <100.00%> (ø)
http3/server.go 69.88% <100.00%> (+1.06%) ⬆️
internal/handshake/crypto_setup.go 66.59% <100.00%> (ø)
internal/handshake/session_ticket.go 100.00% <100.00%> (ø)
internal/wire/ack_frame.go 94.78% <100.00%> (ø)
internal/wire/connection_close_frame.go 94.74% <100.00%> (ø)
internal/wire/crypto_frame.go 95.45% <100.00%> (ø)
internal/wire/data_blocked_frame.go 100.00% <100.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 602212e...f922688. Read the comment docs.

Copy link
Member

@lucas-clemente lucas-clemente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT about s/VarInt//g in the function names in the package? quickvarint.ReadVarInt reads a bit redundant.

@marten-seemann
Copy link
Member Author

That's what the second commit does.

@marten-seemann
Copy link
Member Author

But it looks like I forgot WriteVarInt. Fixed now.

@marten-seemann marten-seemann merged commit d9c7467 into master Jan 2, 2021
@marten-seemann marten-seemann deleted the publicize-varint branch January 2, 2021 04:06
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants