put the session in the packet handler map directly (for client sessions) #2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
remove-unnecessary-client-packet-handler
branch
from
e4d535f
to
fd5f555
Compare
Codecov Report
@@ Coverage Diff @@
## master #2667 +/- ##
==========================================
+ Coverage 86.44% 86.57% +0.14%
==========================================
Files 122 122
Lines 9763 9742 -21
==========================================
- Hits 8439 8434 -5
+ Misses 989 973 -16
Partials 335 335
Continue to review full report at Codecov.
|
|
Increasing test coverage by deleting code. There's no better way to do it :) |
lucas-clemente
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #2640, Version Negotiation packets are now handled in the session. This allows us to put the
sessionin the packet handler map directly, without the need to route packets through theclientfirst.