Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slaves do not stop when master is recreated #1136

Closed
matti opened this issue Nov 9, 2019 · 4 comments
Closed

slaves do not stop when master is recreated #1136

matti opened this issue Nov 9, 2019 · 4 comments
Labels

Comments

@matti
Copy link

matti commented Nov 9, 2019

Describe the bug

  • create a master and 3 slaves
  • start a test
  • recreate master
  • slaves continue running

Expected behavior

slaves should stop

Actual behavior

slaves continue testing

@matti matti added the bug label Nov 9, 2019
@heyman
Copy link
Member

heyman commented Nov 10, 2019

How do you stop the master node? If it's sent a SIGTERM (or if you press CTRL-C) it's supposed to propagate that to the slave nodes which should then also quit.

With the current design, one is not supposed to ever restart the master node while the test is running.

@matti
Copy link
Author

matti commented Nov 10, 2019

Master got killed with power off - I think slaves should stop if connection to original master is lost

@heyman
Copy link
Member

heyman commented Nov 11, 2019

The master is not supposed to be killed in the middle of a running test. I don't see any big gain in making the code more complex by having the slave nodes try to detect that.

@heyman heyman closed this as completed Nov 11, 2019
@heyman heyman added wontfix and removed bug labels Nov 11, 2019
@matti
Copy link
Author

matti commented Nov 11, 2019

okay, fixed it outside of locust codebase for my needs. 👨🏻‍🔧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants