Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚑ perf: remove some blur style to improve performance #4085

Merged
merged 3 commits into from
Sep 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@ import { ChatHeader } from '@lobehub/ui';
import HeaderAction from './HeaderAction';
import Main from './Main';

const Header = () => <ChatHeader left={<Main />} right={<HeaderAction />} style={{ zIndex: 11 }} />;
const Header = () => (
<ChatHeader
left={<Main />}
right={<HeaderAction />}
style={{ minHeight: 64, position: 'initial', zIndex: 11 }}
/>
);

export default Header;
2 changes: 0 additions & 2 deletions src/app/(main)/chat/(workspace)/_layout/Desktop/Portal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { rgba } from 'polished';
import { PropsWithChildren, memo } from 'react';
import { Flexbox } from 'react-layout-kit';

import SafeSpacing from '@/components/SafeSpacing';
import { CHAT_DOCK_TOOL_UI_WIDTH, CHAT_DOCK_WIDTH, MAX_WIDTH } from '@/const/layoutTokens';
import { useChatStore } from '@/store/chat';
import { chatPortalSelectors } from '@/store/chat/slices/portal/selectors';
Expand Down Expand Up @@ -69,7 +68,6 @@ const PortalPanel = memo(({ children }: PropsWithChildren) => {
minWidth: CHAT_DOCK_WIDTH,
}}
>
<SafeSpacing />
<Flexbox className={styles.panel}>{children}</Flexbox>
</DraggablePanelContainer>
</DraggablePanel>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { createStyles, useResponsive } from 'antd-style';
import isEqual from 'fast-deep-equal';
import { PropsWithChildren, memo, useEffect, useState } from 'react';

import SafeSpacing from '@/components/SafeSpacing';
import { CHAT_SIDEBAR_WIDTH } from '@/const/layoutTokens';
import { useChatStore } from '@/store/chat';
import { chatPortalSelectors } from '@/store/chat/slices/portal/selectors';
Expand Down Expand Up @@ -71,7 +70,6 @@ const TopicPanel = memo(({ children }: PropsWithChildren) => {
minWidth: CHAT_SIDEBAR_WIDTH,
}}
>
<SafeSpacing />
{children}
</DraggablePanelContainer>
</DraggablePanel>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,14 @@ import { SessionGroupItem } from '@/types/session';

import GroupItem from './GroupItem';

const useStyles = createStyles(({ css, token, stylish }) => ({
const useStyles = createStyles(({ css, token }) => ({
container: css`
height: 36px;
padding-inline: 8px;
border-radius: ${token.borderRadius}px;
transition: background 0.2s ease-in-out;

&:hover {
${stylish.blur};
background: ${token.colorFillTertiary};
}
`,
Expand Down
1 change: 0 additions & 1 deletion src/components/DragUpload/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ const useStyles = createStyles(({ css, token }) => {
height: 100%;
background: ${token.colorBgMask};
backdrop-filter: blur(4px);
transition: all 0.3s ease-in-out;
`,
Expand Down
1 change: 0 additions & 1 deletion src/components/FunctionModal/style.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ export const useStyles = createStyles(({ css, token, prefixCls, isDarkMode, resp
`,
wrap: css`
overflow: hidden auto;
backdrop-filter: blur(2px);
`,
};
});
Expand Down
1 change: 0 additions & 1 deletion src/components/GuideModal/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ const useStyles = createStyles(({ css, token, prefixCls }) => {
`,
wrap: css`
overflow: hidden auto;
backdrop-filter: blur(2px);
`,
};
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,9 @@ const VirtualizedList = memo<VirtualizedListProps>(({ mobile }) => {

const data = useChatStore((s) => {
const showInboxWelcome = chatSelectors.showInboxWelcome(s);
const ids = showInboxWelcome
return showInboxWelcome
? [WELCOME_GUIDE_CHAT_ID]
: chatSelectors.currentChatIDsWithGuideMessage(s);
return ['empty', ...ids];
}, isEqual);

useEffect(() => {
Expand All @@ -71,11 +70,7 @@ const VirtualizedList = memo<VirtualizedListProps>(({ mobile }) => {
(index: number, id: string) => {
if (id === WELCOME_GUIDE_CHAT_ID) return <InboxWelcome />;

return index === 0 ? (
<div style={{ height: 24 + (mobile ? 0 : 64) }} />
) : (
<Item id={id} index={index - 1} />
);
return <Item id={id} index={index} />;
},
[mobile],
);
Expand Down
1 change: 0 additions & 1 deletion src/layout/AuthProvider/Clerk/useAppearance.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ export const useStyles = createStyles(
`,
modalBackdrop: css`
background: ${token.colorBgMask};
backdrop-filter: blur(2px);
`,
modalContent: css`
&.${prefixCls}-modalContent {
Expand Down
Loading