Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ› fix: fix claude 3.5 image with s3 url #3870

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Conversation

arvinxx
Copy link
Contributor

@arvinxx arvinxx commented Sep 9, 2024

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ‘ท build
  • โšก๏ธ perf
  • ๐Ÿ“ docs
  • ๐Ÿ”จ chore

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

๐Ÿ“ ่กฅๅ……ไฟกๆฏ | Additional Information

Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
lobe-chat-database โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Sep 9, 2024 7:29pm
lobe-chat-preview โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Sep 9, 2024 7:29pm

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 9, 2024
@lobehubbot
Copy link
Member

๐Ÿ‘ @arvinxx

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

@dosubot dosubot bot added the ๐Ÿ› Bug Something isn't working | ็ผบ้™ท label Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 91.82%. Comparing base (eb552d2) to head (8a6ac89).
Report is 110 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3870      +/-   ##
==========================================
+ Coverage   91.68%   91.82%   +0.14%     
==========================================
  Files         455      455              
  Lines       30414    30433      +19     
  Branches     3087     1964    -1123     
==========================================
+ Hits        27884    27946      +62     
+ Misses       2530     2487      -43     
Flag Coverage ฮ”
app 91.82% <100.00%> (+0.14%) โฌ†๏ธ
server 97.36% <รธ> (รธ)

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 9, 2024
@lobehubbot
Copy link
Member

โค๏ธ Great PR @arvinxx โค๏ธ

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
้กน็›ฎ็š„ๆˆ้•ฟ็ฆปไธๅผ€็”จๆˆทๅ้ฆˆๅ’Œ่ดก็Œฎ๏ผŒๆ„Ÿ่ฐขๆ‚จ็š„่ดก็Œฎ! ๅฆ‚ๆžœๆ‚จๅฏน LobeHub ๅผ€ๅ‘่€…็คพๅŒบๆ„Ÿๅ…ด่ถฃ๏ผŒ่ฏทๅŠ ๅ…ฅๆˆ‘ไปฌ็š„ discord๏ผŒ็„ถๅŽ็งไฟก @arvinxx ๆˆ– @canisminor1990ใ€‚ไป–ไปฌไผš้‚€่ฏทๆ‚จๅŠ ๅ…ฅๆˆ‘ไปฌ็š„็งๅฏ†ๅผ€ๅ‘่€…้ข‘้“ใ€‚ๆˆ‘ไปฌๅฐ†ไผš่ฎจ่ฎบๅ…ณไบŽ Lobe Chat ็š„ๅผ€ๅ‘๏ผŒๅˆ†ไบซๅ’Œ่ฎจ่ฎบๅ…จ็ƒ่Œƒๅ›ดๅ†…็š„ AI ๆถˆๆฏใ€‚

github-actions bot pushed a commit that referenced this pull request Sep 9, 2024
### [Version&nbsp;1.15.30](v1.15.29...v1.15.30)
<sup>Released on **2024-09-09**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Fix claude 3.5 image with s3 url.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix claude 3.5 image with s3 url, closes [#3870](#3870) ([89c8dd4](89c8dd4))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

๐ŸŽ‰ This PR is included in version 1.15.30 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Sep 10, 2024
### [Version&nbsp;1.58.15](v1.58.14...v1.58.15)
<sup>Released on **2024-09-10**</sup>

#### โ™ป Code Refactoring

- **misc**: Refactor brand implement for better custom.

#### ๐Ÿ› Bug Fixes

- **misc**: Baichuan should not introduce `freequency_penality` parameters, fix `/etc/resolv.conf`edit permission in docker image, fix claude 3.5 image with s3 url, fix tools calling in some edge cases, Gemini cannot input images when server database is enabled, Update baichuan param.

#### ๐Ÿ’„ Styles

- **misc**: Add siliconcloud new model.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Refactor brand implement for better custom, closes [lobehub#3868](https://github.com/bentwnghk/lobe-chat/issues/3868) ([815b366](815b366))

#### What's fixed

* **misc**: Baichuan should not introduce `freequency_penality` parameters, closes [lobehub#3871](https://github.com/bentwnghk/lobe-chat/issues/3871) ([66a061e](66a061e))
* **misc**: Fix `/etc/resolv.conf`edit permission in docker image, closes [lobehub#3880](https://github.com/bentwnghk/lobe-chat/issues/3880) ([fdaa190](fdaa190))
* **misc**: Fix claude 3.5 image with s3 url, closes [lobehub#3870](https://github.com/bentwnghk/lobe-chat/issues/3870) ([89c8dd4](89c8dd4))
* **misc**: Fix tools calling in some edge cases, closes [lobehub#3872](https://github.com/bentwnghk/lobe-chat/issues/3872) ([2ed759d](2ed759d))
* **misc**: Gemini cannot input images when server database is enabled, closes [lobehub#3370](https://github.com/bentwnghk/lobe-chat/issues/3370) ([eb552d2](eb552d2))
* **misc**: Update baichuan param, closes [lobehub#3356](https://github.com/bentwnghk/lobe-chat/issues/3356) ([29bced1](29bced1))

#### Styles

* **misc**: Add siliconcloud new model, closes [lobehub#3865](https://github.com/bentwnghk/lobe-chat/issues/3865) ([c6b5a45](c6b5a45))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment