From 242f4e85eb5caa462a9835ac85c49e4a78dc1703 Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Sat, 10 Aug 2024 23:45:47 -0700 Subject: [PATCH] [profgen][NFC] Pass parameter as const_ref Pass `ProbeNode` parameter of `trackInlineesOptimizedAway` as const reference. Reviewers: wlei-llvm, WenleiHe Reviewed By: WenleiHe Pull Request: https://github.com/llvm/llvm-project/pull/102787 --- llvm/include/llvm/MC/MCPseudoProbe.h | 1 + llvm/tools/llvm-profgen/ProfiledBinary.cpp | 3 ++- llvm/tools/llvm-profgen/ProfiledBinary.h | 7 ++++--- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/llvm/include/llvm/MC/MCPseudoProbe.h b/llvm/include/llvm/MC/MCPseudoProbe.h index 54a7f832e50081..13ad1c38f3b3b0 100644 --- a/llvm/include/llvm/MC/MCPseudoProbe.h +++ b/llvm/include/llvm/MC/MCPseudoProbe.h @@ -241,6 +241,7 @@ class MCPseudoProbeInlineTreeBase { InlinedProbeTreeMap &getChildren() { return Children; } const InlinedProbeTreeMap &getChildren() const { return Children; } std::vector &getProbes() { return Probes; } + const std::vector &getProbes() const { return Probes; } void addProbes(ProbeType Probe) { Probes.push_back(Probe); } // Caller node of the inline site MCPseudoProbeInlineTreeBase *Parent = diff --git a/llvm/tools/llvm-profgen/ProfiledBinary.cpp b/llvm/tools/llvm-profgen/ProfiledBinary.cpp index 632ddc7b50f54a..574a9c9f52bf18 100644 --- a/llvm/tools/llvm-profgen/ProfiledBinary.cpp +++ b/llvm/tools/llvm-profgen/ProfiledBinary.cpp @@ -137,7 +137,8 @@ void BinarySizeContextTracker::trackInlineesOptimizedAway( void BinarySizeContextTracker::trackInlineesOptimizedAway( MCPseudoProbeDecoder &ProbeDecoder, - MCDecodedPseudoProbeInlineTree &ProbeNode, ProbeFrameStack &ProbeContext) { + const MCDecodedPseudoProbeInlineTree &ProbeNode, + ProbeFrameStack &ProbeContext) { StringRef FuncName = ProbeDecoder.getFuncDescForGUID(ProbeNode.Guid)->FuncName; ProbeContext.emplace_back(FuncName, 0); diff --git a/llvm/tools/llvm-profgen/ProfiledBinary.h b/llvm/tools/llvm-profgen/ProfiledBinary.h index f2eeca45454592..0588cb48b2af62 100644 --- a/llvm/tools/llvm-profgen/ProfiledBinary.h +++ b/llvm/tools/llvm-profgen/ProfiledBinary.h @@ -167,9 +167,10 @@ class BinarySizeContextTracker { void trackInlineesOptimizedAway(MCPseudoProbeDecoder &ProbeDecoder); using ProbeFrameStack = SmallVector>; - void trackInlineesOptimizedAway(MCPseudoProbeDecoder &ProbeDecoder, - MCDecodedPseudoProbeInlineTree &ProbeNode, - ProbeFrameStack &Context); + void + trackInlineesOptimizedAway(MCPseudoProbeDecoder &ProbeDecoder, + const MCDecodedPseudoProbeInlineTree &ProbeNode, + ProbeFrameStack &Context); void dump() { RootContext.dumpTree(); }