Skip to content

Commit

Permalink
perf machine: Add threads__set_last_match function
Browse files Browse the repository at this point in the history
Separating threads::last_match cache set into separate
threads__set_last_match function.  This will be useful in following
patch.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Lukasz Odzioba <lukasz.odzioba@intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/20180719143345.12963-3-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
olsajiri authored and acmel committed Jul 24, 2018
1 parent f8b2ebb commit 67fda0f
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions tools/perf/util/machine.c
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,12 @@ threads__get_last_match(struct threads *threads, struct machine *machine,
return NULL;
}

static void
threads__set_last_match(struct threads *threads, struct thread *th)
{
threads->last_match = th;
}

/*
* Caller must eventually drop thread->refcnt returned with a successful
* lookup/new thread inserted.
Expand All @@ -453,7 +459,7 @@ static struct thread *____machine__findnew_thread(struct machine *machine,
th = rb_entry(parent, struct thread, rb_node);

if (th->tid == tid) {
threads->last_match = th;
threads__set_last_match(threads, th);
machine__update_thread_pid(machine, th, pid);
return thread__get(th);
}
Expand Down Expand Up @@ -490,7 +496,7 @@ static struct thread *____machine__findnew_thread(struct machine *machine,
* It is now in the rbtree, get a ref
*/
thread__get(th);
threads->last_match = th;
threads__set_last_match(threads, th);
++threads->nr;
}

Expand Down Expand Up @@ -1648,7 +1654,7 @@ static void __machine__remove_thread(struct machine *machine, struct thread *th,
struct threads *threads = machine__threads(machine, th->tid);

if (threads->last_match == th)
threads->last_match = NULL;
threads__set_last_match(threads, NULL);

BUG_ON(refcount_read(&th->refcnt) == 0);
if (lock)
Expand Down

0 comments on commit 67fda0f

Please sign in to comment.