Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] fix flakey pubsub test #709

Closed
jacobheun opened this issue Jul 14, 2020 · 4 comments · Fixed by #741
Closed

[tests] fix flakey pubsub test #709

jacobheun opened this issue Jul 14, 2020 · 4 comments · Fixed by #741
Labels
kind/bug A bug in existing code (including security flaws) status/ready Ready to be worked

Comments

@jacobheun
Copy link
Contributor

One of the pubsub tests intermittently fails with timeout issues, we need to correct this. Here is the log of the failing test:

Pubsub subsystem operates correctly
       pubsub with intermittent connections
         should handle quick reconnects with a delayed disconnect:
     Error: Timeout of 5000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/travis/build/libp2p/js-libp2p/test/pubsub/operation.node.js)
      at listOnTimeout (internal/timers.js:549:17)
      at processTimers (internal/timers.js:492:7)
@jacobheun jacobheun added kind/bug A bug in existing code (including security flaws) status/ready Ready to be worked labels Jul 14, 2020
@vasco-santos
Copy link
Member

@jacobheun can you replicate this locally?
I have never seen that test failing and I just tried it out locally several times running only the pubsub tests

@jacobheun
Copy link
Contributor Author

No, i've just seen it in CI. The latest run was linux node 10 here, https://github.com/libp2p/js-libp2p/runs/869245153. We likely just need the test to be more thorough with when events are happening.

@vasco-santos
Copy link
Member

I could not replicate it yet. Let me know if you see this in CI again. #698 might also help with this

@vasco-santos
Copy link
Member

I got it now, it is stil la valid issue: https://travis-ci.com/github/libp2p/js-libp2p/jobs/361764759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) status/ready Ready to be worked
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants