Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(@libp2p): Add protocol-perf to release workflow. #1964

Closed
Tracked by #2118
maschad opened this issue Aug 14, 2023 · 1 comment
Closed
Tracked by #2118

feat(@libp2p): Add protocol-perf to release workflow. #1964

maschad opened this issue Aug 14, 2023 · 1 comment
Labels
kind/test Testing work P1 High: Likely tackled by core team if no one steps up

Comments

@maschad
Copy link
Member

maschad commented Aug 14, 2023 •
edited
Loading

Once the perf workflow is integrated in test-plans we should run the benchmarks on our release workflow

Can be added once libp2p/test-plans#280 is merged
@maschad maschad added the need/triage Needs initial labeling and prioritization label Aug 14, 2023
@maschad maschad self-assigned this Aug 14, 2023
@maschad maschad added P1 High: Likely tackled by core team if no one steps up kind/test Testing work and removed need/triage Needs initial labeling and prioritization labels Aug 14, 2023
@maschad maschad mentioned this issue Aug 25, 2023
Merged
@SgtPooki SgtPooki mentioned this issue Oct 3, 2023
Open
@maschad maschad removed their assignment May 2, 2024
@achingbrain
Copy link
Member

achingbrain commented May 14, 2024 •
edited
Loading

Closing as running a full performance test in CI will not give us much confidence without dedicated testing infrastructure.

A lighter touch such as proposed in #2120 will likely be more useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/test Testing work P1 High: Likely tackled by core team if no one steps up
Projects
js-libp2p
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@achingbrain @maschad