From 0b55625d146940994a306101650a55ee58e32f6c Mon Sep 17 00:00:00 2001 From: Alex Potsides Date: Sun, 23 Jun 2024 22:59:07 +0200 Subject: [PATCH] fix: move mplex capabilities to the factory (#2597) These should be defined on the factory not the instance, since the factory is the component. --- packages/stream-multiplexer-mplex/src/index.ts | 7 +++++++ packages/stream-multiplexer-mplex/src/mplex.ts | 8 +------- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/packages/stream-multiplexer-mplex/src/index.ts b/packages/stream-multiplexer-mplex/src/index.ts index 2766d94929..88b03db1e9 100644 --- a/packages/stream-multiplexer-mplex/src/index.ts +++ b/packages/stream-multiplexer-mplex/src/index.ts @@ -31,6 +31,7 @@ * ``` */ +import { serviceCapabilities } from '@libp2p/interface' import { MplexStreamMuxer, type MplexComponents } from './mplex.js' import type { StreamMuxer, StreamMuxerFactory, StreamMuxerInit } from '@libp2p/interface' @@ -91,6 +92,12 @@ class Mplex implements StreamMuxerFactory { this._init = init } + readonly [Symbol.toStringTag] = '@libp2p/mplex' + + readonly [serviceCapabilities]: string[] = [ + '@libp2p/stream-multiplexing' + ] + createStreamMuxer (init: StreamMuxerInit = {}): StreamMuxer { return new MplexStreamMuxer(this.components, { ...init, diff --git a/packages/stream-multiplexer-mplex/src/mplex.ts b/packages/stream-multiplexer-mplex/src/mplex.ts index 20b9799bcb..23746b9660 100644 --- a/packages/stream-multiplexer-mplex/src/mplex.ts +++ b/packages/stream-multiplexer-mplex/src/mplex.ts @@ -1,4 +1,4 @@ -import { CodeError, serviceCapabilities } from '@libp2p/interface' +import { CodeError } from '@libp2p/interface' import { closeSource } from '@libp2p/utils/close-source' import { RateLimiter } from '@libp2p/utils/rate-limiter' import { pipe } from 'it-pipe' @@ -120,12 +120,6 @@ export class MplexStreamMuxer implements StreamMuxer { }) } - readonly [Symbol.toStringTag] = '@libp2p/mplex' - - readonly [serviceCapabilities]: string[] = [ - '@libp2p/stream-multiplexing' - ] - /** * Returns a Map of streams and their ids */