This repository has been archived by the owner on May 7, 2024. It is now read-only.
fix: allow dialling ip6 webtransport addresses #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SgtPooki
commented
Mar 23, 2023
•
SgtPooki
commented
- fix: use valid rfc3986 ipv6 host syntax
SgtPooki
force-pushed
the
fix/ip6-webtransport-url-construct-failures
branch
from
da150aa
to
12a340e
Compare
achingbrain
suggested changes
Mar 24, 2023
|
Just seen this in the wild I think: |
achingbrain
approved these changes
Mar 28, 2023
achingbrain
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Mar 28, 2023
## [1.0.11](v1.0.10...v1.0.11) (2023-03-28) ### Bug Fixes * allow dialling ip6 webtransport addresses ([#60](#60)) ([fe4612a](fe4612a))
|
🎉 This PR is included in version 1.0.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Isn't this going to be an issue anywhere we dial ipv6 addresses? |
With JS, yep. The URL constructor requires the brackets for ip6 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.