[switch] Connection manager and PeerBook report different numbers of connected peers #428
Comments
daviddias
changed the title
|
This should not be a problem anymore as only the connectionManager stores connections now. |
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this issue
Jun 21, 2023
p-queue@7.3.4 contained a breaking change so update it's use to get the correct return types.
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this issue
Jun 21, 2023
## [7.0.1](libp2p/js-libp2p-kad-dht@v7.0.0...v7.0.1) (2023-03-10) ### Bug Fixes * correct `KBucketTree` types ([libp2p#426](libp2p/js-libp2p-kad-dht#426)) ([ea8e6d0](libp2p/js-libp2p-kad-dht@ea8e6d0)), closes [/github.com/tristanls/k-bucket/blob/3aa5b4f1dacb835752995a25409ab319d2070b9e/index.js#L413](https://github.com/libp2p//github.com/tristanls/k-bucket/blob/3aa5b4f1dacb835752995a25409ab319d2070b9e/index.js/issues/L413) * update p-queue types ([libp2p#428](libp2p/js-libp2p-kad-dht#428)) ([f5b85fc](libp2p/js-libp2p-kad-dht@f5b85fc)) ### Trivial Changes * replace err-code with CodeError ([libp2p#413](libp2p/js-libp2p-kad-dht#413)) ([e05d2a0](libp2p/js-libp2p-kad-dht@e05d2a0)), closes [js-libp2p#1269](libp2p#1269) * Update .github/workflows/semantic-pull-request.yml [skip ci] ([a70ab3f](libp2p/js-libp2p-kad-dht@a70ab3f)) * Update .github/workflows/semantic-pull-request.yml [skip ci] ([1652c6c](libp2p/js-libp2p-kad-dht@1652c6c)) * Update .github/workflows/semantic-pull-request.yml [skip ci] ([ea13c2a](libp2p/js-libp2p-kad-dht@ea13c2a))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Logging out some stats on a running node, eventually the number of peers reported as connected via the
Connection ManagerandPeerBookstarts to differ pretty dramatically. In this instance almost 160 peers.The
Connection Managerconnections are taken directly from the_peersmap in the connection manager. The mapping is updated anytime a muxed connection is created or ends.The
PeerBookconnections are determined by thePeerInfoinstances inPeerBookthat return an address fromPeerInfo.isConnected(). These numbers should match. If not, the connection manager might not be pruning connections at the correct high water mark.The text was updated successfully, but these errors were encountered: