Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

Readme documentation drift #178

Open
paralin opened this issue Jun 13, 2022 · 5 comments
Open

Readme documentation drift #178

paralin opened this issue Jun 13, 2022 · 5 comments
Labels
help wanted Seeking public contribution on this issue kind/stale P3 Low: Not priority right now

Comments

@paralin
Copy link
Contributor

paralin commented Jun 13, 2022

Hi,

It appears the readme is out of date - it's written as if MplexStreamMuxer was exported as Muxer, but instead there's the new factory approach in place.

Am I correct on this?

@achingbrain
Copy link
Member

I don't know how useful the API docs in this repo are - it's an implementation of interface-stream-muxer so really only the deviations from that API should be documented otherwise it's redundant and liable to get out of date.

Would you like to open a PR to improve the docs?

@achingbrain achingbrain added the need/author-input Needs input from the original author label Aug 30, 2022
@paralin
Copy link
Contributor Author

paralin commented Aug 30, 2022

I've not got the time to do that this week but if it remains unsolved long enough I can take a look.

As far as I can tell the interface docs are also wrong - they say "import Muxer from your-muxer-pkg; new Mixer()" which doesn't work, needs the Factory pattern.

@BigLep BigLep added help wanted Seeking public contribution on this issue P3 Low: Not priority right now labels Sep 13, 2022
@BigLep
Copy link

BigLep commented Sep 13, 2022

@paralin : core maintainers are not going to get to this work anytime soon. We'll certainly review if you make a PR though. Any help is welcome. Thanks.

@github-actions
Copy link

Oops, seems like we needed more information for this issue, please comment with more details or this issue will be closed in 7 days.

@paralin
Copy link
Contributor Author

paralin commented Sep 20, 2022

Commenting to keep the issue open.

@BigLep BigLep removed the need/author-input Needs input from the original author label Sep 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Seeking public contribution on this issue kind/stale P3 Low: Not priority right now
Projects
None yet
Development

No branches or pull requests

3 participants