Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

Switch to using multihashes for DHT queries #163

Closed
achingbrain opened this issue Dec 10, 2019 · 3 comments
Closed

Switch to using multihashes for DHT queries #163

achingbrain opened this issue Dec 10, 2019 · 3 comments
Labels
exp/expert Having worked on the specific codebase is important kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked

Comments

@achingbrain
Copy link
Member

go-IPFS is switching to use multihashes only for DHT queries so this module should do the same thing.

@aschmahmann has proposed accepting CIDs as arguments in the API but only sending the multihash portion over the wire when making the query.

Context: libp2p/go-libp2p#755

@alanshaw
Copy link
Member

Tracking libp2p/go-libp2p-kad-dht#422

@vasco-santos vasco-santos added exp/expert Having worked on the specific codebase is important kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked labels Dec 13, 2019
@jacobheun jacobheun added this to the Spec Compliant DHT milestone Jul 28, 2020
@jacobheun
Copy link
Contributor

For future reference, there is some discussion around adding CID prefixes to provider records in order to keep data structure knowledge with the usage of just mulithashes, libp2p/go-libp2p-kad-dht#559 (comment).

@achingbrain
Copy link
Member Author

This was fixed in #237

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
exp/expert Having worked on the specific codebase is important kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
None yet
Development

No branches or pull requests

4 participants